Merged
Conversation
* feat: collect email for subscription * feat: add API to send email & test locally * feat: write test cases for subscription APIs * refactor: add comment * feat: add test for send-email API * feat: validating email and add contants * refactor: change file extension * feat: add test for invalid email * feat: add feature flag * refactor: change config details * refactor: change test email * fix: change phone number to optional * fix: make phoneNumber optional * fix: change API name * fix: change API name * fix: try-catch Indain phone numbers controllers * fix: put to patch * feat: add devFlagMiddleware * fix: comments * fix: return message * remove: comments * fix: failing test case * fix: add test cases * fix: remove comment * fix: custom environment variables * rename: emailSubscriptonCrenderials --------- Co-authored-by: Vinit khandal <111434418+vinit717@users.noreply.github.com>
* adding new route for query param profile * removing some mixed changes of other commit * modified test cases and and controller logic * Implemented GET route /users?profile=true to fetch user's details * refactored: moved authentication logic from controller to middleware * test cases fo authCondition file * updated test cases and routes and middleware of users * bug fix for using only in test cases * code refactor and updated function naming
Contributor
|
Staging Testing Proof for #2201 ScreenshotsScreenshot 1
Screenshot 2
Screenshot 3
Screenshot 4
|
iamitprakash
approved these changes
Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date: 17-Oct-2024
Developer Name: @vikasosmium, @tejaskh3, @MayankBansal12
Issue Ticket Number
#2123 (Please don't close this issue)
#2126
#2206
PR List
#2124
#2201
#2212
Description
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Test Coverage
Screenshot 1
Additional Notes