generated from RealDevSquad/website-template
-
Notifications
You must be signed in to change notification settings - Fork 31
Fix: alias error while running storybook #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
harshith-venkatesh
merged 1 commit into
develop
from
Fix--Path-Alias-Error-in-Storybook
Apr 14, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,19 @@ | ||
| import { Story, Meta } from '@storybook/react'; | ||
| import { Event } from '~/utils/interfaces'; | ||
| import EventCard from '../components/common/eventCard/index'; | ||
| import { CalEvent } from '~/utils/interfaces'; | ||
| import EventCard from '~/components/common/eventCard/index'; | ||
|
|
||
| export default { | ||
| title: 'Components/EventCard', | ||
| component: EventCard, | ||
| argTypes: { | ||
| name: { control: 'text' }, | ||
| title: { control: 'text' }, | ||
| }, | ||
| } as Meta; | ||
|
|
||
| const Template: Story<Event> = (args: Event) => <EventCard {...args} />; | ||
| const Template: Story<CalEvent> = (args: CalEvent) => <EventCard {...args} />; | ||
|
|
||
| export const Primary = Template.bind({}); | ||
| Primary.args = { | ||
| name: 'Example Event', | ||
| title: 'Example Event', | ||
| attendees: [], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit pick:
There is a general practise of using
@instead of~for path alias.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samyakshah3008 Has this been considered as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use
@then we need to change it everywhere in our codebase where we have used~Shall I do it in this PR? @harshith-venkatesh @iRohitGaur ? Your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be a one-time Change I feel should not be a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider it as it is application level change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great in that case, please go ahead and create a ticket linking this PR as well and mention the expectations of that ticket.
We can assign the ticket to the beginner as well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*issue
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disagree here, if the paths are set right there will not be any problem as I have done this before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I got confused with the intent of the ticket and its impact which had led to this discussion.
Thanks for providing more clarity @yesyash @samyakshah3008
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great, I have raised a ticket #143 @harshith-venkatesh @yesyash 😄
Thanks @yesyash for bringing out this discussion!