Allow users of the driver to disable query formatting; support named parameters in QueryStmt, DMLStmt#43
Merged
ohaibbq merged 2 commits intocandidate/rb20240201from Apr 11, 2024
Conversation
ohaibbq
requested review from
a team,
ageiduschek,
colincadams,
emilyemilyemilyemilyemilyemily,
ethan-oro and
recidinick
recidinick
approved these changes
Apr 10, 2024
recidinick
left a comment
recidinick
left a comment
There was a problem hiding this comment.
Really cool and really good find!
ohaibbq
changed the title
QueryStmtQueryStmt, DMLStmt
ageiduschek
approved these changes
Apr 11, 2024
ohaibbq
added a commit
that referenced
this pull request
Jun 29, 2024
…parameters in `QueryStmt`, `DMLStmt` (#43) * Allow users of the driver to disable query formatting * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of goccy/bigquery-emulator#294 we want to be able to disable query formatting for queries in order to fine-tune the query plans generated by SQLite.
This implements an option that can be used to disable formatting as well as supports named parameters.