You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Core code changed? - Tested with other Redocly products (internal contributions only)
New package installed? - Tested in different environments (browser/node)
Documentation update has been considered
Security
The security impact of the change has been considered
Code follows company security practices and guidelines
Note
Medium Risk
Medium risk because it changes the shape/typing of directResolveAs and array items in the core type-normalization pipeline, which can affect how config/YAML nodes are resolved at runtime. The rest are typing-only tweaks plus a small utility boolean change and stricter test coverage thresholds.
Overview
Refactors core schema type normalization to use fully normalized nested types: NormalizedScalarSchema.items now recursively uses NormalizedScalarSchema, and NormalizedNodeType.directResolveAs is typed as a NormalizedNodeType (with resolveType updated to handle functions, named types, and directResolveAs more explicitly).
Fixes a typing issue in redocly-yaml’s extends schema builder by removing an incorrect cast and aligning directResolveAs with the new normalized node type expectations. Separately tightens OpenAPI/Swagger typings (Record<string, …> and unknown), makes isNotEmptyArray check explicit, and raises Vitest coverage thresholds slightly.
Reviewed by Cursor Bugbot for commit 2c0d4e7. Bugbot is set up for automated code reviews on this repo. Configure here.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Refactored types for better readability and fixed wrong ones.
Needed for https://github.com/Redocly/redocly/pull/22749.
Pipeline, E2E and integration tests passed here and here.
Check yourself
Security
Note
Medium Risk
Medium risk because it changes the shape/typing of
directResolveAsand arrayitemsin the core type-normalization pipeline, which can affect how config/YAML nodes are resolved at runtime. The rest are typing-only tweaks plus a small utility boolean change and stricter test coverage thresholds.Overview
Refactors core schema type normalization to use fully normalized nested types:
NormalizedScalarSchema.itemsnow recursively usesNormalizedScalarSchema, andNormalizedNodeType.directResolveAsis typed as aNormalizedNodeType(withresolveTypeupdated to handle functions, named types, anddirectResolveAsmore explicitly).Fixes a typing issue in
redocly-yaml’sextendsschema builder by removing an incorrect cast and aligningdirectResolveAswith the new normalized node type expectations. Separately tightens OpenAPI/Swagger typings (Record<string, …>andunknown), makesisNotEmptyArraycheck explicit, and raises Vitest coverage thresholds slightly.Reviewed by Cursor Bugbot for commit 2c0d4e7. Bugbot is set up for automated code reviews on this repo. Configure here.