Skip to content

fix: script-src in csp#29

Merged
Daryna-del merged 5 commits intomainfrom
fix/csp
Jul 7, 2025
Merged

fix: script-src in csp#29
Daryna-del merged 5 commits intomainfrom
fix/csp

Conversation

@Daryna-del
Copy link
Copy Markdown
Contributor

What/Why/How?

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@Daryna-del Daryna-del marked this pull request as ready for review July 7, 2025 06:24
@Daryna-del Daryna-del requested a review from RomanHotsiy July 7, 2025 06:24
Copy link
Copy Markdown
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test all the pages? Make sure to test forms (hubspot)
If so, let's merge and see.

@Daryna-del
Copy link
Copy Markdown
Contributor Author

Did you test all the pages? Make sure to test forms (hubspot) If so, let's merge and see.

I tested all pages, and double-tested pages with hubspot forms (they were loading correctly), but I didn't test submitting forms and found that we needed more improvements to csp.

After merging I will double check on the prod if every form works correctly.

@RomanHotsiy
Copy link
Copy Markdown
Member

okay, go ahead and merge. Make sure to test submitting forms plz

@Daryna-del Daryna-del merged commit f6fb1d9 into main Jul 7, 2025
4 of 5 checks passed
@Daryna-del Daryna-del deleted the fix/csp branch July 7, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants