Remove comparison as these conditions are never true#1062
Merged
langou merged 2 commits intoReference-LAPACK:masterfrom Oct 15, 2024
Merged
Remove comparison as these conditions are never true#1062langou merged 2 commits intoReference-LAPACK:masterfrom
langou merged 2 commits intoReference-LAPACK:masterfrom
Conversation
Collaborator
|
looks like these comparisons came in with #540 @weslleyspereira |
langou
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The problem is that dtpmqrt is impossible to use because
sidemust be eitherl(L) orr(R). The condition not only usesLAPACKE_lsameto compare against the possible values, but also compare the boolean result againstside(which is achar). This situation ultimately leads to a logical expression that will never be true, making it impossible to usedtpmqrtand others routines affected by similar code. The commit simply removesside ==as this fix the problem.Checklist