Regression test for illegal modification of Y in xGEMV.#622
Merged
weslleyspereira merged 2 commits intoReference-LAPACK:masterfrom Apr 15, 2022
Merged
Regression test for illegal modification of Y in xGEMV.#622weslleyspereira merged 2 commits intoReference-LAPACK:masterfrom
weslleyspereira merged 2 commits intoReference-LAPACK:masterfrom
Conversation
…MV observed with Apple vecLib on SGEMV and DGEMV.
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1894 1894
Lines 184021 184021
=======================================
Misses 184021 184021 Continue to review full report at Codecov.
|
weslleyspereira
approved these changes
Sep 20, 2021
Collaborator
weslleyspereira
left a comment
weslleyspereira
left a comment
There was a problem hiding this comment.
Thanks! Your tests make sense to me, I don't think it is necessary to change the input files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At NAG we've observed that Apple vecLib modifies Y on output from SGEMV and DGEMV when TRANS is 'T', M is zero, and N is nonzero.
Here is a test case for all four xGEMV's and four xGBMV's.
(It looked unnecessary to try to incorporate this into the data-file mechanism that the xblat2 tests use, so I hope this is OK.)