RR-T42 Bug fixes by ucswift · Pull Request #111 · Resgrid/Responder

ucswift · 2026-03-20T18:57:02Z

Summary by CodeRabbit

Tests
- Enhanced Jest test infrastructure with mocks for localization, device wake-lock functionality, and UI components.
Localization
- Updated translation keys and content across multiple languages (Arabic, English, Spanish, Polish) to improve language selector consistency.
Style
- Minor JSX formatting adjustment in login form component.

coderabbitai · 2026-03-20T18:57:19Z

📝 Walkthrough

Walkthrough

This PR establishes Jest mock infrastructure for Expo libraries and extends existing React Native mocks with I18nManager support. New mocks are created for expo-keep-awake and expo-localization, test mocks are added for the login form, translation files are updated with reordered language keys, and the login form component receives minor JSX reformatting.

Changes

Cohort / File(s)	Summary
Expo and React Native Jest Mocks `__mocks__/expo-keep-awake.ts`, `__mocks__/expo-localization.ts`, `__mocks__/react-native.ts`, `jest-setup.ts`	Created new mock modules for `expo-keep-awake` with async and sync mock functions; added `expo-localization` mock with locale, calendar, and RTL data; extended React Native mock with `I18nManager` API including `allowRTL`, `forceRTL`, and `isRTL` state.
Login Form Test Setup `src/app/login/__tests__/login-form.test.tsx`	Added Jest mocks for Select component hierarchy, extended React Native mock with `I18nManager`, added `GlobeIcon` to icon mocks, and configured `react-i18next` mock with `initReactI18next` plugin support.
Login Form Component `src/app/login/login-form.tsx`	Reformatted Select component JSX from multi-line to single-line syntax without functional changes.
Translation Files `src/translations/ar.json`, `src/translations/en.json`, `src/translations/es.json`, `src/translations/pl.json`	Reordered language selection keys in login/settings sections across multiple translation files; updated Polish translation string with Unicode escape sequences for special quotation characters.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

CU-868ex18rd Working on geolocation issue minor fixes. #67: Both PRs extend mocks in the login form test file, adding and configuring test dependencies for component and library mocking.
CU-868ex18rd Expo 53 update. #69: Directly overlaps in creating/updating Jest mocks for expo-keep-awake, expo-localization, and React Native I18nManager configuration.
RR-T42 Fixing translations #110: Shares changes to Jest mocks for internationalization (I18nManager, expo-localization) and language-selection translation keys used in the Select component.

Poem

🐰 Hops of joy through mock arrays,
Locale whispers, RTL sways,
Languages dance in JSON files so bright,
Test setup springs—all mocks in sight! 🌍✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'RR-T42 Bug fixes' is vague and generic, using non-descriptive terms that don't convey what specific bugs are being fixed or the main focus of the changeset.	Replace with a more specific title that describes the primary change, such as 'Add Jest mocks for expo-keep-awake and expo-localization with i18n support' or 'Add internationalization and RTL support mocks for testing'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@__mocks__/react-native.ts`:
- Around line 37-41: The I18nManager mock is missing the swapLeftAndRightInRTL
property used in jest-setup.ts and src/app/login/__tests__/login-form.test.tsx;
update the I18nManager export in __mocks__/react-native.ts to include
swapLeftAndRightInRTL (as a jest.fn() or boolean as appropriate for the mock) so
the mock API matches the real I18nManager and the tests that call
swapLeftAndRightInRTL do not get undefined.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d4de7e79-5102-44a5-b1ee-7ad25c60a24a

📥 Commits

Reviewing files that changed from the base of the PR and between 113c4d2 and 58085b9.

📒 Files selected for processing (10)

__mocks__/expo-keep-awake.ts
__mocks__/expo-localization.ts
__mocks__/react-native.ts
jest-setup.ts
src/app/login/__tests__/login-form.test.tsx
src/app/login/login-form.tsx
src/translations/ar.json
src/translations/en.json
src/translations/es.json
src/translations/pl.json

coderabbitai · 2026-03-20T19:03:35Z

__mocks__/react-native.ts

+export const I18nManager = {
+  allowRTL: jest.fn(),
+  forceRTL: jest.fn(),
+  isRTL: false,
+};


⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash set -euo pipefail echo "== I18nManager usage and API members ==" rg -n -C2 '\bI18nManager\b|\bswapLeftAndRightInRTL\b' --type ts --type tsx echo echo "== __mocks__/react-native.ts excerpt ==" sed -n '30,80p' __mocks__/react-native.ts echo echo "== jest-setup.ts excerpt ==" sed -n '318,336p' jest-setup.ts

Repository: Resgrid/Responder

Length of output: 145

🏁 Script executed:

#!/bin/bash set -euo pipefail echo "== __mocks__/react-native.ts (lines 30-80) ==" cat -n __mocks__/react-native.ts | sed -n '30,80p' echo echo "== jest-setup.ts (searching for I18nManager) ==" grep -n -A5 'I18nManager' jest-setup.ts || echo "Not found in jest-setup.ts" echo echo "== Search for swapLeftAndRightInRTL usage ==" rg -n 'swapLeftAndRightInRTL' || echo "No matches found" echo echo "== Search for I18nManager usage across codebase ==" rg -n 'I18nManager' -t ts || echo "No matches in .ts files"

Repository: Resgrid/Responder

Length of output: 2370

Add swapLeftAndRightInRTL to keep I18nManager mock API consistent.

The I18nManager mock at lines 37-41 is missing swapLeftAndRightInRTL, which is defined in jest-setup.ts and actively used in src/app/login/__tests__/login-form.test.tsx. This API surface mismatch can cause undefined behavior if tests import from __mocks__/react-native.ts instead of relying on the jest-setup definition.

🔧 Proposed fix

export const I18nManager = { allowRTL: jest.fn(), forceRTL: jest.fn(), + swapLeftAndRightInRTL: jest.fn(), isRTL: false, };

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

export const I18nManager = {

allowRTL: jest.fn(),

forceRTL: jest.fn(),

isRTL: false,

};

export const I18nManager = {

allowRTL: jest.fn(),

forceRTL: jest.fn(),

swapLeftAndRightInRTL: jest.fn(),

isRTL: false,

};

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@__mocks__/react-native.ts` around lines 37 - 41, The I18nManager mock is missing the swapLeftAndRightInRTL property used in jest-setup.ts and src/app/login/__tests__/login-form.test.tsx; update the I18nManager export in __mocks__/react-native.ts to include swapLeftAndRightInRTL (as a jest.fn() or boolean as appropriate for the mock) so the mock API matches the real I18nManager and the tests that call swapLeftAndRightInRTL do not get undefined.

ucswift · 2026-03-20T19:04:42Z

Approve

github-actions

This PR is approved.

RR-T42 Bug fixes

58085b9

coderabbitai bot reviewed Mar 20, 2026

View reviewed changes

github-actions bot approved these changes Mar 20, 2026

View reviewed changes

ucswift merged commit f6e22ba into master Mar 20, 2026
13 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RR-T42 Bug fixes#111

RR-T42 Bug fixes#111
ucswift merged 1 commit intomasterfrom
develop

ucswift commented Mar 20, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 20, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Mar 20, 2026

Uh oh!

ucswift commented Mar 20, 2026

Uh oh!

github-actions bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ucswift commented Mar 20, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

ucswift commented Mar 20, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ucswift commented Mar 20, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 20, 2026 •

edited

Loading