hf felica dump: vastly improve speed; fix traces being empty#3095
Merged
iceman1001 merged 1 commit intoRfidResearchGroup:masterfrom Feb 15, 2026
Merged
Conversation
|
You are welcome to add an entry to the CHANGELOG.md as well |
Collaborator
|
the felica commands should be converted to use NG packages instead too. Nice PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hf felica dumpandhf felica scsvcodecommands by preventing the cyclic tear-down and activation of the RF field on each command-response cycle.hf felica dumpnot saving logs by cleaning the buffer and creating new "connection" only on start of the command.hf felica raw.I've tested the following
hf felicacommands after the change:reader,dump,litedump,rqservice,rqresponse,scsvcode,rqsyscode,rqspecver,resetmode,raw.