feat: private chat global admin + manual verification + bug fixes#5
Merged
feat: private chat global admin + manual verification + bug fixes#5
Conversation
Execute ADMIN-CHAT-TEST-PLAN.md via Playwright on Telegram Web: - 26/29 tests pass, 3 skipped (need second Telegram account) - Fix: google_search + Function Calling cannot coexist in API Key mode - Update test plan with execution results and skip reasons Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1. Narrow search_knowledge tool description so Gemini won't route general questions (e.g. "現在幾點") to the knowledge base. 2. Block binary MIME types (.docx/.xlsx/.pptx/images/etc.) from being extracted as text, and add looksLikeBinary() safety net for unknown types that slip through (detects null bytes and ZIP magic bytes). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SAFE_FOLDER_RE), timing-safe secret comparison (safeCompare), type validation on all tool argssearch_knowledgetool description to prevent Gemini from routing general questions (e.g. "現在幾點") to the knowledge baselooksLikeBinary()heuristic to prevent .docx/.xlsx binary garbage from being indexedTest plan
npm run typecheck— passesnpm test— 66 plugin tests pass, full suite passesdocs/ADMIN-CHAT-TEST-PLAN.md)[Binary file — cannot extract text]instead of garbage🤖 Generated with Claude Code