added the alert logic for the coordinators with no on chain swap#1804
Merged
KoalaSat merged 2 commits intoRoboSats:mainfrom Mar 11, 2025
Merged
added the alert logic for the coordinators with no on chain swap#1804KoalaSat merged 2 commits intoRoboSats:mainfrom
KoalaSat merged 2 commits intoRoboSats:mainfrom
Conversation
khadar1020
force-pushed
the
alert-user-for-coordinators
branch
from
fd74ac2 to
e2b607c
Compare
Signed-off-by: khadar vali <khadarvali@khadars-MacBook-Air.local>
khadar1020
force-pushed
the
alert-user-for-coordinators
branch
from
e2b607c to
f2f6f2d
Compare
Contributor
Author
|
Hi @KoalaSat can you please review my PR Thank you |
Member
|
@khadar1020 the code looks good, but you sure you ran the pre-commit? ideally it should have generated automatically this new sentence on all json locale files |
KoalaSat
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1786
For the coordinators who do not support the on chain payments if the user locked the money in bond and user only supports on chain payments it might be a problem so giving an simple alert message for the user this coordinator does not support on chain payments with out disturbing any flow of his work
Thank you
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.