Skip to content

increase tests trade range #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KoalaSat merged 2 commits into from
May 20, 2025
Merged

increase tests trade range #1937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5640734
increase tests trade range
jerryfletcher21 May 17, 2025
74f9015
Merge branch 'main' into increase-test-trade-range
KoalaSat May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/test_trade_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,8 @@ def test_make_order_on_blocked_country(self):
"type": 0,
"currency": 1,
"has_range": True,
"min_amount": 21,
"max_amount": 101.7,
"min_amount": 84,
"max_amount": 201.7,
"payment_method": "Advcash Cash F2F",
"is_explicit": False,
"premium": 3.34,
Expand Down Expand Up @@ -434,7 +434,7 @@ def test_make_and_take_order(self):
)
self.assertIsHash(data["maker_hash_id"])
self.assertEqual(data["maker_status"], "Active")
self.assertAlmostEqual(float(data["amount"]), 80)
self.assertAlmostEqual(float(data["amount"]), 100)
self.assertFalse(data["is_maker"])
self.assertFalse(data["is_buyer"])
self.assertTrue(data["is_seller"])
Expand Down Expand Up @@ -474,7 +474,7 @@ def test_make_and_take_range_order(self):
self.assertResponse(trade.response)

self.assertEqual(data["status_message"], Order.Status(Order.Status.PUB).label)
self.assertAlmostEqual(float(data["amount"]), 80)
self.assertAlmostEqual(float(data["amount"]), 100)

# Cancel order to avoid leaving pending HTLCs after a successful test
trade.cancel_order()
Expand Down
6 changes: 3 additions & 3 deletions tests/utils/trade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
"type": Order.Types.BUY,
"currency": 1,
"has_range": True,
"min_amount": 21,
"max_amount": 101.7,
"min_amount": 84,
"max_amount": 201.7,
"payment_method": "Advcash Cash F2F",
"is_explicit": False,
"premium": 3.34,
Expand All @@ -47,7 +47,7 @@ def __init__(
self,
client,
maker_form=maker_form_buy_with_range,
take_amount=80,
take_amount=100,
maker_index=1,
taker_index=2,
third_index=3,
Expand Down