ensure nostr pubkey is present in auth when creating robot#1985
Merged
KoalaSat merged 1 commit intoRoboSats:mainfrom Jun 26, 2025
Merged
Conversation
Member
|
This change can't be possible while some folks run old frontend versions that are not sending nostr pubkey. Fortunately for us robodats clients always force users to upgrade if they detect a major new version on any of the coordinatros. That means these changes will only be possible with v0.8.0. |
Contributor
Author
|
@KoalaSat yes I understand. But it has been reported by other coordinators that there are now problems in sending the messages and completing the orders when nostr_pubkey is not present. It think it may be better to block the creation of robots all together and force them to update instead of allowing to create robots and not being able to complete the trades for old clients. |
KoalaSat
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since nostr is becoming necessary for the trade process, this PR checks that the nostr_pubkey is present in the authorization header when creating a robot.
It also documents the presence of nostr_pubkey in some comments.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.