add option for routing_budget_ppm in /api/rewards#2038
add option for routing_budget_ppm in /api/rewards#2038KoalaSat merged 1 commit intoRoboSats:mainfrom
Conversation
3fa9222 to
e90701a
Compare
| ) | ||
| body = { | ||
| "invoice": signed_payout_invoice, | ||
| "routing_budget_ppm": 0 |
There was a problem hiding this comment.
I think it's worth to leave this test as it is and create a new one specifically sending a custom number here
There was a problem hiding this comment.
added a new test
e90701a to
997c569
Compare
|
Thanks again for your continuous support @jerryfletcher21 please accept a small tip for this work. Share here a LN invoice for 30,000 sats with a long expiration date. |
|
|
|
|
|
@KoalaSat thank you!
|
Oh! Would you mind to post on each to them a new invoice and tag me? just to keep the record of every payment associated to every PR |
|
thanks🙏 |
|
Thank you! |
What does this PR do?
This PR uniforms the
/api/rewardswith the/api/orderupdate_invoice(changed in #326), adding the optionrouting_budget_ppmin/api/rewards, and thus fixing #1382 for the backend.An other pull request implementing it in the frontend is needed (maybe to be incorporated in #1973). This commit still leaves the option to not specify
routing_budget_ppmin order to be compatible with old clients, with the notice in the code that it should be deprecated in the future.It also remove the
MIN_FLAT_ROUTING_FEE_LIMITvariable from.env-sample, since after #347 it is no longer used.Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.