Ignore case differences during payment methods icon matching#2131
Merged
KoalaSat merged 1 commit intoRoboSats:mainfrom Aug 1, 2025
Merged
Ignore case differences during payment methods icon matching#2131KoalaSat merged 1 commit intoRoboSats:mainfrom
KoalaSat merged 1 commit intoRoboSats:mainfrom
Conversation
aftermath2
force-pushed
the
external_pix_orders_icon
branch
from
0acba04 to
262891c
Compare
aftermath2
changed the title
Member
|
I just wrote on the issue and didn´t even realize you just fixed it 😄 thanks! Please accept a small tip for your help. Paste here a LN invoice with a long expiration date for 40,000 sats |
KoalaSat
approved these changes
Aug 1, 2025
Contributor
Author
|
@KoalaSat Haha we thought about the same solution. Thanks! |
|
77c7a71ffc9c20b96ce023ea76613500bd0c02d4153b5a9d13996df6c978210e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2130
This PR modifies the way in which payment methods icons are detected by using lowecase in both sides (known payment methods and the ones used by the user). This helps avoid scenarios in which a payment method is not detected because of different cases in the name (i.e.
PIX,Pix,pix,PiX, etc.)Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.