Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pre release fixes v0.8.1
Fixes #2132
And the following reports:
1- When I am creating a robot and copy the token, the token disappears and the robot is not created. It is also possible to edit this field, maybe it should be blocked.
2- Timestamp on notifications are wrong (1/21/1970, 7:12:49 AM, for example) and I eventually needed to refresh the browser to receive the notification.
4- When I choose an order and until the chat opens, it is not possible to see the order id and robot names (these are the first things I ask when someone sends me a message, at least order id visible would be interesting).
5- AUDIT CHAT -> NOSTR: public key is always the same (npub106246s) and your private key is empty (even exporting a file)
AUDIT CHAT -> PGP: your public key, your encrypted private key and your private key passphrase also empty.
The chat works well even one robot using NOSTR and the other API.
6- If you enable Orbot connection, it is not possible to disable even restarting the phone. I needed to reinstall the app.
7- It is not possible to save the keys in a file (NOSTR and PGP) - Error message: Invalid content for clipboard.
8- When the offer list is expanded, the filter buttons are not well aligned, but they can be used.
9- "COPY URL" button is not working when creating an order - Error message: Invalid content for clipboard.
12- When I click on the QR code, it shows the message "Copied!" but only the button "COPY TO CLIPBOARD" works.
13- When the chat is open, the same error that happens on the desktop happens here: AUDIT CHAT without some keys.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.