Skip to content

fix tor error messaging when safer or safest mode is enabled in tor#2300

Merged
KoalaSat merged 2 commits intoRoboSats:mainfrom
hbdc-BtcFixesThis:handle_tor_security_mode_errors_and_noscript
Nov 13, 2025
Merged

fix tor error messaging when safer or safest mode is enabled in tor#2300
KoalaSat merged 2 commits intoRoboSats:mainfrom
hbdc-BtcFixesThis:handle_tor_security_mode_errors_and_noscript

Conversation

@hbdc-BtcFixesThis
Copy link
Contributor

The main div was always being displayed; causing the spinner to never leave. It is now hidden when js is disabled. This pr also hides it for safer mode because without wsm the app hangs so checking for wsm was used as a hack to see if the page can load correctly. this is why the noscript error is duplicated; since it applies to both safer and safest modes yet only gets displayed if js is completely disabled

these are screenshots taken when testing the fix on chrome

Screenshot 2025-11-12 at 1 11 43 AM Screenshot 2025-11-12 at 1 11 59 AM

screenshots taken when testing on tor

Screenshot 2025-11-12 at 1 13 42 AM Screenshot 2025-11-12 at 1 13 22 AM Screenshot 2025-11-12 at 1 13 04 AM

What does this PR do?

Fixes #<ISSUE_NUMBER>

Copy link
Member

@KoalaSat KoalaSat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ey @hbdc-BtcFixesThis thanks for your code this will be helpful for newcomers. Please, accept a small tip for your work.

Share here a LN invoice for 65,000 sats with a long expiration date.

@KoalaSat KoalaSat merged commit 5827d4a into RoboSats:main Nov 13, 2025
5 checks passed
@hbdc-BtcFixesThis
Copy link
Contributor Author

@KoalaSat I'm really glad to hear that. I really appreciate it. Let me know if I can help with anything else! Great work on a great app. I am proud to be a small part of it

lnbc650u1p53vkygpp5gf3qp5m8ds7r60xt3msn9y24lru8gqnxjgwlu4f5qc6a5u03nk8qcqzyssp5ph52060zs585vfyy5wqum7dyqveqkvrvaz2uqkhg6mw7slr75q2s9q7sqqqqqqqqqqqqqqqqqqqsqqqqqysgqdq5w35hqgrxdaezqam0wf4smqz9gxqyjw5qrzjqwryaup9lh50kkranzgcdnn2fgvx390wgj5jd07rwr3vxeje0glcllmvd66r5ymnjgqqqqlgqqqqqeqqjq8l40hpx4ejvfen5xwhh9ppdef7f43kj67mkh7m9c4tcqff69qhmhnvkn725ztdplych0ewtcfl3wz900t7q3zu42wcca8asm6jkp6zgq9rmf4d

@KoalaSat
Copy link
Member

Let me know if I can help with anything else! Great work on a great app. I am proud to be a small part of it

You can always check the issues! I try to always use tags to help figuring out what's the required knowledge

@RobosatsDevFund
Copy link

@hbdc-BtcFixesThis sorry for the delay, can you please paste a new invoice with a long expiration date?

@hbdc-BtcFixesThis hbdc-BtcFixesThis deleted the handle_tor_security_mode_errors_and_noscript branch December 31, 2025 20:03
@hbdc-BtcFixesThis
Copy link
Contributor Author

That's ok, thank you for not forgetting about me. Happy new year!

bitcoin:BC1Q7L0L7EAJZGMTUC0TUN9JSUNSYRWPKSMNSJDV9Q?lightning=LNBC650U1P542LLHPP5D7YD27ZAZGP2QZ60KAXFQCZAGQMLS043UZ5LDYY946EH2KCXF3NSDQQCQZZSXQ9ZF6SQSP50WVYZTEC3ZC7WFCCZL8X4HUY7075GLXU5V7T02K6K4CU00Y966CS9QXPQYSGQHQ3GX33RKSUNPVSQJKD5MZ7JME9YE9DPKSEYZHTWEGPYXK2800MXMRGV8RUMV2GWY7MP2QAAS5DY3T5YFCZ0RXFLC82NEAETJ5SDTUCQW3KL7G&amount=0.00065

@RobosatsDevFund
Copy link

a485ea1939aa5f5ceb18ecdce70b03e554bda03eb17b65772780d6a338f1d5ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants