fix tor error messaging when safer or safest mode is enabled in tor#2300
Conversation
KoalaSat
left a comment
There was a problem hiding this comment.
Ey @hbdc-BtcFixesThis thanks for your code this will be helpful for newcomers. Please, accept a small tip for your work.
Share here a LN invoice for 65,000 sats with a long expiration date.
|
@KoalaSat I'm really glad to hear that. I really appreciate it. Let me know if I can help with anything else! Great work on a great app. I am proud to be a small part of it lnbc650u1p53vkygpp5gf3qp5m8ds7r60xt3msn9y24lru8gqnxjgwlu4f5qc6a5u03nk8qcqzyssp5ph52060zs585vfyy5wqum7dyqveqkvrvaz2uqkhg6mw7slr75q2s9q7sqqqqqqqqqqqqqqqqqqqsqqqqqysgqdq5w35hqgrxdaezqam0wf4smqz9gxqyjw5qrzjqwryaup9lh50kkranzgcdnn2fgvx390wgj5jd07rwr3vxeje0glcllmvd66r5ymnjgqqqqlgqqqqqeqqjq8l40hpx4ejvfen5xwhh9ppdef7f43kj67mkh7m9c4tcqff69qhmhnvkn725ztdplych0ewtcfl3wz900t7q3zu42wcca8asm6jkp6zgq9rmf4d |
You can always check the issues! I try to always use tags to help figuring out what's the required knowledge |
|
@hbdc-BtcFixesThis sorry for the delay, can you please paste a new invoice with a long expiration date? |
|
That's ok, thank you for not forgetting about me. Happy new year! bitcoin:BC1Q7L0L7EAJZGMTUC0TUN9JSUNSYRWPKSMNSJDV9Q?lightning=LNBC650U1P542LLHPP5D7YD27ZAZGP2QZ60KAXFQCZAGQMLS043UZ5LDYY946EH2KCXF3NSDQQCQZZSXQ9ZF6SQSP50WVYZTEC3ZC7WFCCZL8X4HUY7075GLXU5V7T02K6K4CU00Y966CS9QXPQYSGQHQ3GX33RKSUNPVSQJKD5MZ7JME9YE9DPKSEYZHTWEGPYXK2800MXMRGV8RUMV2GWY7MP2QAAS5DY3T5YFCZ0RXFLC82NEAETJ5SDTUCQW3KL7G&amount=0.00065 |
|
a485ea1939aa5f5ceb18ecdce70b03e554bda03eb17b65772780d6a338f1d5ff |
The main div was always being displayed; causing the spinner to never leave. It is now hidden when js is disabled. This pr also hides it for safer mode because without wsm the app hangs so checking for wsm was used as a hack to see if the page can load correctly. this is why the noscript error is duplicated; since it applies to both safer and safest modes yet only gets displayed if js is completely disabled
these are screenshots taken when testing the fix on chrome
screenshots taken when testing on tor
What does this PR do?
Fixes #<ISSUE_NUMBER>