Skip to content

Fix external orders empty link #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KoalaSat merged 1 commit into from
Nov 13, 2025
Merged

Fix external orders empty link #2302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 20 additions & 13 deletions frontend/src/components/Dialogs/VisitThirdParty.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,14 @@ const VisitThirdParty = ({ open, onClose, thirdPartyOrder }: Props): React.JSX.E
<DialogTitle>{t('Open external order')}</DialogTitle>
<DialogContent>
<DialogContentText>
{t(
'This order is not managed by a RoboSats coordinator. Please ensure you are comfortable with the privacy and trust trade-offs. You will open an external link or app',
)}
{thirdPartyOrder?.link
? t(
'This order is not managed by a RoboSats coordinator. Please ensure you are comfortable with the privacy and trust trade-offs. You will open an external link or app',
)
: t(
"This order is not managed by a RoboSats coordinator. {{alias}} does not provide web access to it; please check {{alias}}'s platform for more details.",
{ alias: thirdPartyOrder?.coordinatorShortAlias },
)}
</DialogContentText>
</DialogContent>
<DialogActions>
Expand All @@ -38,16 +43,18 @@ const VisitThirdParty = ({ open, onClose, thirdPartyOrder }: Props): React.JSX.E
>
{t('Cancel')}
</Button>
<Button
onClick={() => {
if (thirdPartyOrder?.link) window.open(thirdPartyOrder?.link, '_blank')?.focus();
onClose();
}}
>
{t('Browser')}
<div style={{ width: '0.5em' }} />
<NewTabIcon sx={{ width: '0.7em', height: '0.7em' }} />
</Button>
{thirdPartyOrder?.link && (
<Button
onClick={() => {
if (thirdPartyOrder?.link) window.open(thirdPartyOrder?.link, '_blank')?.focus();
onClose();
}}
>
{t('Browser')}
<div style={{ width: '0.5em' }} />
<NewTabIcon sx={{ width: '0.7em', height: '0.7em' }} />
</Button>
)}
</DialogActions>
</Dialog>
);
Expand Down
1 change: 0 additions & 1 deletion frontend/src/components/RobotInfo/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ const RobotInfo: React.FC<Props> = ({ coordinator, onClose }: Props) => {
if (robot?.token && robot.encPrivKey != null) {
void signCleartextMessage(rewardInvoice, robot.encPrivKey, robot?.token).then(
(signedInvoice) => {
console.log('Signed message:', signedInvoice);
void robot.fetchReward(federation, signedInvoice).then((data) => {
setBadInvoice(data.bad_invoice ?? '');
setShowRewardsSpinner(false);
Expand Down
1 change: 1 addition & 0 deletions frontend/src/models/Slot.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class Slot {
this.robots = shortAliases.reduce((acc: Record<string, Robot>, shortAlias: string) => {
acc[shortAlias] = new Robot({
...robotAttributes,
token,
shortAlias,
hasEnoughEntropy,
bitsEntropy,
Expand Down