regression: modal touchables not working after RNGH migration#7101
Merged
regression: modal touchables not working after RNGH migration#7101
Conversation
Contributor
WalkthroughFive modal-containing components have been updated to wrap their modal content with Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
Right now Profile update test is failing because of rate limit issue, which we are going to fix this issue in separate PR. |
diegolmello
pushed a commit
that referenced
this pull request
Apr 7, 2026
Co-authored-by: Otávio Stasiak <91474186+OtavioStasiak@users.noreply.github.com>
diegolmello
pushed a commit
that referenced
this pull request
Apr 8, 2026
Co-authored-by: Otávio Stasiak <91474186+OtavioStasiak@users.noreply.github.com>
diegolmello
pushed a commit
that referenced
this pull request
Apr 8, 2026
Co-authored-by: Otávio Stasiak <91474186+OtavioStasiak@users.noreply.github.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Buttons are not clickable inside some modals, including the two-factor authentication modal. This regression was introduced in #6997
As mentioned in https://docs.swmansion.com/react-native-gesture-handler/docs/fundamentals/installation/#android, we need to wrap the modal content with
GestureHandlerRootViewto allowRectButtonto receive press events inside the modal. This was missed in a few places.Issue(s)
https://rocketchat.atlassian.net/browse/CORE-2062
Closes: #7102
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit