-
Notifications
You must be signed in to change notification settings - Fork 13.1k
chore: use lastTokenPart as stable key for personal access tokens list #38630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
chore: use lastTokenPart as stable key for personal access tokens list #38630
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughThe React element key for rendering AccountTokensRow in the Personal Access Tokens table was updated from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx,js}📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
Files:
🧠 Learnings (1)📚 Learning: 2026-01-17T01:51:47.764ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
✏️ Tip: You can disable this entire section by setting Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38630 +/- ##
===========================================
- Coverage 70.45% 70.43% -0.02%
===========================================
Files 3174 3174
Lines 111005 111005
Branches 20000 20007 +7
===========================================
- Hits 78207 78187 -20
- Misses 30758 30775 +17
- Partials 2040 2043 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
This PR replaces
createdAtwithlastTokenPartas the Reactkeyfor rows in the Personal Access Tokens list.Using
createdAtas a key is not guaranteed to be unique or stable, especially if tokens are regenerated or reordered.lastTokenPartprovides a stable and unique identifier, making it more appropriate for use as a React key and aligning the implementation with React best practices.This change does not introduce user-facing behavior changes and is categorized as a small internal improvement (
chore).Issue(s)
Closes #38563
Steps to test or reproduce
/account/tokens).AccountTokensRowcomponents.lastTokenPartas the React key instead ofcreatedAt.There should be no visible UI changes, but the internal rendering now uses a stable key.
Further comments
This is a small, isolated code quality improvement to ensure stable and predictable list rendering in accordance with React best practices. No changeset is included, as this does not introduce a user-facing change or require a version bump.
Summary by CodeRabbit