Add support for drachtio to voip helm chart #207
Conversation
There was a problem hiding this comment.
Include something like:
https://github.com/RocketChat/helm-charts/blob/c99e92931fd2e23f567e13c487156e17fe7022fe/monitoring/templates/validations.yaml
to force the user to change the secret, also include an option to useExistingSecret , so they can reuse a pre-existing secret and avoid plain text secrets in tools like helm-controller or kustomize helm-chart inflating.
There was a problem hiding this comment.
i dont see that particular validation in there 🤔
There was a problem hiding this comment.
It was an example of how we did; the validation in this case would be something like
{{ if or (eq .Values.drachtio.secret "changeme!!!") (eq .Values.drachtio.secret "") }}
{{- fail "Change password please" -}}
{{- end -}}
|
Maybe whould be nice to add a dummy test like we did for the monitoring chart, https://github.com/RocketChat/helm-charts/blob/c99e92931fd2e23f567e13c487156e17fe7022fe/monitoring/tests/tests.bats Really basic, just deploy the previous version of chart, them the new one, so we can ensure that chart is deployed before a release is created. |
This seems a bit out of scope for this PR, but i can make a new one adding tests since there were no tests previously for the voip chart. |
2 participants
Drachtio is the new backend for voip used by Rocket.Chat. It's used for internal call routing. For external calls, freeswitch is still needed, hence it's presence in the updated helm chart.