[IdleShutdown] Don't reload the settings every second#364
Merged
RogueMaster merged 2 commits intoRogueMaster:420from Oct 15, 2022
Merged
[IdleShutdown] Don't reload the settings every second#364RogueMaster merged 2 commits intoRogueMaster:420from
RogueMaster merged 2 commits intoRogueMaster:420from
Conversation
Owner
|
Thank you! |
Owner
|
Can you check if this is still an issue with the latest changes from the original PR, and refix if necessary? @lokiuox https://github.com/RogueMaster/flipperzero-firmware-wPlugins/blob/420/0.69.1-1018-RM-0303.tgz |
Author
|
I tested the new release and it works correctly, no other fixes are necessary |
Owner
|
TY! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
The current implementation of the "Shutdown on Idle" features reloads the power settings file every second to check for changes in the settings. (The
auto_shutdown_update()is called inside the main power service loop). This behaviour is also verifiable by checking the logs from the serial console, since they get spammed by[I][SavedStruct] Loading "/int/.power.settings"messages.This behavior is wasteful and could be detrimental on the internal memory. The simplest solution to fix this (implemented here) is to just reboot the Flipper when the setting is changed from the menu, i.e. the same thing that happens when the battery style is changed. The Flipper will just reload the new config on the next boot and no continuous checks are needed.
Verification
Monitor the logs from the serial console to verify that the Loading calls are no more being spammed every second.
Checklist (For Reviewer)