Skip to content

BUG FIX: dev server port must be configured via VITE_PORT#234

Merged
pedramamini merged 1 commit intoRunMaestro:mainfrom
ksylvan:kayvan/fix-for-hardcoded-dev-port
Jan 24, 2026
Merged

BUG FIX: dev server port must be configured via VITE_PORT#234
pedramamini merged 1 commit intoRunMaestro:mainfrom
ksylvan:kayvan/fix-for-hardcoded-dev-port

Conversation

@ksylvan
Copy link
Copy Markdown
Contributor

@ksylvan ksylvan commented Jan 24, 2026

BUG FIX: dev server port must be configured via VITE_PORT

Summary

We need to avoid using the hardcoded localhost:5173 for the dev server and localhost:5174 for the web dev server.

Recent commits broke my MaestroDev launcher, which uses

# Vite port for main renderer (optional - defaults to 5198)
# shellcheck disable=SC2034
VITE_PORT=5198

# Vite port for web interface (optional - defaults to 5199)
# shellcheck disable=SC2034
VITE_WEB_PORT=5199

CHANGES

  • Extract dev server port and URL into separate variables
  • Add radix parameter to parseInt for proper number parsing
  • Sync port configuration between Vite config and main process
  • Use consistent port parsing with explicit base 10 radix

…riable

## CHANGES

- Extract dev server port and URL into separate variables
- Add radix parameter to `parseInt` for proper number parsing
- Sync port configuration between Vite config and main process
- Use consistent port parsing with explicit base 10 radix
@ksylvan ksylvan changed the title fix: make dev server port configurable via VITE_PORT BUG FIX: dev server port must be configured via VITE_PORT Jan 24, 2026
@ksylvan
Copy link
Copy Markdown
Contributor Author

ksylvan commented Jan 24, 2026

@pedramamini Please merge this. Thanks.

@pedramamini pedramamini merged commit 965a049 into RunMaestro:main Jan 24, 2026
1 check failed
@ksylvan ksylvan deleted the kayvan/fix-for-hardcoded-dev-port branch January 24, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants