BUG FIX: dev server port must be configured via VITE_PORT#234
Merged
pedramamini merged 1 commit intoRunMaestro:mainfrom Jan 24, 2026
Merged
Conversation
…riable ## CHANGES - Extract dev server port and URL into separate variables - Add radix parameter to `parseInt` for proper number parsing - Sync port configuration between Vite config and main process - Use consistent port parsing with explicit base 10 radix
VITE_PORTVITE_PORT
Contributor
Author
|
@pedramamini Please merge this. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG FIX: dev server port must be configured via
VITE_PORTSummary
We need to avoid using the hardcoded localhost:5173 for the dev server and localhost:5174 for the web dev server.
Recent commits broke my MaestroDev launcher, which uses
CHANGES
parseIntfor proper number parsing