Skip to content

Conversation

@Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Jan 7, 2026

I've upstreamed some changes to install-vulkan-sdk-action and the maintainer made some fixes, and want to test them in our pipeline:

I've asked if the registry entry could be added by the action itself: jakoch/install-vulkan-sdk-action#547

This PR also serves as a testing ground for that patch and should showcase that in some scenarios setting VK_DRIVER_FILES without formally adding the driver to the windows registry is sufficient. See jakoch/install-vulkan-sdk-action#547 for ongoing investigation. Resolved: windows-2022 is fine without registration, windows-2025 requires it though.

close #407

@Firestar99 Firestar99 force-pushed the ci_remove_swiftshader_setup branch from 988f4e6 to 5d2ce94 Compare January 7, 2026 13:25
@Firestar99 Firestar99 changed the title ci: remove swiftshader setup ci: fix swiftshader download timeouts Jan 7, 2026
@Firestar99 Firestar99 changed the title ci: fix swiftshader download timeouts ci: fix swiftshader rate limit exceeded Jan 7, 2026
@Firestar99 Firestar99 marked this pull request as ready for review January 7, 2026 13:55
@Firestar99 Firestar99 enabled auto-merge January 7, 2026 13:55
@Firestar99 Firestar99 disabled auto-merge January 7, 2026 14:13
Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking these issues up with the upstream GH action!

(had no idea about GITHUB_TOKEN, makes sense as a mechanism, but feels convoluted for what it is - or, well, it might make more sense to "just" have a more direct "delegate permissions" every time an action is invoked)

@Firestar99
Copy link
Member Author

Wow, I did not expect that fail. Seems like since windows-2025, just setting VK_DRIVER_FILES is not sufficient and you actually need to register the driver in the registry.

@Firestar99 Firestar99 added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit 2deaf6a Jan 7, 2026
13 checks passed
@Firestar99 Firestar99 deleted the ci_remove_swiftshader_setup branch January 7, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: swiftshader rate limit exceeded

3 participants