Extract JWT Implementation for Dynamic Log Levels #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change extracts all java-jwt dependencies into its own submodule. When running without dynamic log levels this dependency is no longer required. If the JWT-based dynamic log levels are still required, the new Maven module `cf-java-logging-support-servelt-dynlog-jwt` needs to be added. Extensibility is provided via SPI. The Spring Boot sample app was changed and demonstrates. how a custom secrets handling can be implemented. It no longer uses compile-time generated key-pairs but reads them from a (user-defined) serivce. If no config is found, it generates a key pair on startup. Signed-off-by: Karsten Schnitter <[email protected]>
KarstenSchnitter
force-pushed
the
release-4
branch
from
5a132ba to
564945e
Compare
KarstenSchnitter
changed the title
|
|
||
| static String createPublicKeyPem(PublicKey key) { | ||
| String encoded = Base64.getEncoder().encodeToString(key.getEncoded()); | ||
| StringBuilder sb = new StringBuilder("-----BEGIN PUBLIC KEY-----\n"); |
Contributor
There was a problem hiding this comment.
Suggested change
| StringBuilder sb = new StringBuilder("-----BEGIN PUBLIC KEY-----\n"); | |
| StringBuilder sb = new StringBuilder("-----BEGIN PUBLIC KEY-----").append(System.lineSeparator()); |
Comment on lines
+14
to
+15
| for (int i = 0; i < encoded.length() / 64 + 1; i++) { | ||
| sb.append(encoded, i * 64, Math.min(encoded.length(), (i + 1) * 64)).append("\n"); |
Contributor
There was a problem hiding this comment.
Suggested change
| for (int i = 0; i < encoded.length() / 64 + 1; i++) { | |
| sb.append(encoded, i * 64, Math.min(encoded.length(), (i + 1) * 64)).append("\n"); | |
| for (int i = 0; i < encoded.length(); i += 64) { | |
| sb.append(encoded, i, Math.min(i + 64, encoded.length())) | |
| .append(System.lineSeparator()); |
juergen-walter
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extracts all java-jwt dependencies into its own submodule. When running without dynamic log levels this dependency is no longer required. If the JWT-based dynamic log levels are still required, the new Maven module
cf-java-logging-support-servelt-dynlog-jwtneeds to be added. Extensibility is provided via SPI.The Spring Boot sample app was changed and demonstrates. how a custom secrets handling can be implemented. It no longer uses compile-time generated key-pairs but reads them from a (user-defined) serivce. If no config is found, it generates a key pair on startup.