Skip to content

Conversation

@Sakthieswaran-tech
Copy link
Contributor

  • Show default value when input is empty.
  • Pressing Tab fills the prompt with default or selected choice.
  • Added test to verify default display, prefill behavior, and correct selection.

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@6963b18). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/search/src/index.ts 86.36% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1915   +/-   ##
=======================================
  Coverage        ?   94.72%           
=======================================
  Files           ?       37           
  Lines           ?     1554           
  Branches        ?      461           
=======================================
  Hits            ?     1472           
  Misses          ?       80           
  Partials        ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines 632 to 633
"? Select a Canadian province (New)
❯ Alberta
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little weird the default value does nothing here.

Also, is this really a default value? Or a starting search string? Like here if we press enter, there's no valid value selected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I missed one part of the flow.
When there's no search term, the first item gets auto-selected, but this conflicts with how defaultValue is expected to work—Enter should pick the default.

Could you clarify what the intended behavior should be here? That will help me proceed correctly.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think there's 2 things:

  1. We should select the default value on load
  2. We should validate that the default value is valid and exists

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve updated the prompt so the default value is now selected on load and properly validated. Please have a look and let me know if any further changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants