Skip to content

Conversation

@cliu02
Copy link
Collaborator

@cliu02 cliu02 commented Dec 9, 2025

Description

Fixes a typo from 014c4da.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3812

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, use DAH-000 if it does not need a ticket
  • PR name follows urgent: Description format if it is urgent and does not need a ticket

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • if the PR is a bugfix, there are tests and logs around the bug

Code conventions

  • web pages are formatted with .scss stylesheets and ui-seeds tokens, rather than inline styles or Tailwind

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance (PA) testing

  • PA tested in the review environment (use needs product acceptance label)
  • if PA testing cannot be done, changes are behind a feature flag

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2757 December 9, 2025 00:58 Inactive
@cliu02 cliu02 added the needs review Pull request needs review label Dec 9, 2025
@cliu02 cliu02 requested review from a team and josh-chou and removed request for a team December 9, 2025 19:26
@cliu02 cliu02 merged commit bf1dbc6 into main Dec 9, 2025
23 checks passed
@cliu02 cliu02 deleted the DAH-3812-fix-building-name branch December 9, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Pull request needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants