Conversation
There was a problem hiding this comment.
Pull request overview
Adds queue-based routing for the Event NPC, including a bypass permission, and wires in the queue API dependency. Also updates a lobby teleport location and bumps the plugin snapshot version.
Changes:
- Route Event NPC interaction through the queue API (with optional queue bypass permission).
- Add
surf.lobby.queue.bypasspermission and require thesurf-queue-paperserver dependency. - Adjust
SURVIVAL_TELEPORTcoordinates/yaw and bump project version.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/kotlin/dev/slne/surf/lobby/utils/PermissionRegistry.kt |
Adds QUEUE_BYPASS permission node for skipping the queue. |
src/main/kotlin/dev/slne/surf/lobby/utils/Locations.kt |
Updates survival teleport destination coordinates and facing. |
src/main/kotlin/dev/slne/surf/lobby/hook/npc/SurfNpcHook.kt |
Uses queue API to enqueue players for the event server and supports bypass. |
gradle.properties |
Bumps snapshot version to …3.0.6-SNAPSHOT. |
build.gradle.kts |
Adds queue API dependency and marks surf-queue-paper as required. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } ?: error("Event server with name ${lobbyConfig.eventServerName} not found") | ||
| } |
There was a problem hiding this comment.
queueToEventServer ends with ?: error(...) if the configured event server can't be found. Since this method is triggered by a player interaction, this will throw an exception at runtime for every click (spamming logs) instead of failing gracefully. Prefer logging the misconfiguration once and sending the player an error message, then returning without throwing.
No description provided.