refactor: replace PushbackManager scheduled task with event-driven CircularBoundingBox#30
Merged
TheBjoRedCraft merged 2 commits intotrello/tp-falsch-punch-sound-pushback-laggyfrom Mar 15, 2026
Conversation
…gBox-based PlayerMoveEvent approach Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add bounding box around executor for performance improvements
refactor: replace PushbackManager scheduled task with event-driven CircularBoundingBox
Mar 15, 2026
TheBjoRedCraft
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the polling-based
runAtFixedRatepushback system with aPlayerMoveEvent-driven approach using per-executor circular bounding boxes.Changes
CircularBoundingBox— new utility class for 2D circular containment checks using squared distance (no sqrt)PushbackManager— remove scheduled task, maintain aMap<UUID, CircularBoundingBox>per executor instead of aSet<UUID>updateExecutorPosition(player)— moves the box center on executor movecheckPushback(player)— non-executors checkisInside()against all active boxes, with 1s cooldownPlayerMoveListener— drives both methods on every position changePaperMain— removePushbackManager.startTask()callHow it works
Both paths bail out fast for the common case (non-executor with no nearby boxes). The
isInsidecheck is a simpledx² + dz² ≤ r²comparison rather thangetNearbyPlayers()entity scanning every second.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
downloads.gradle.org/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -Xmx64m -Xms64m -Dorg.gradle.appname=gradlew -jar /home/REDACTED/work/surf-lobby/surf-lobby/gradle/wrapper/gradle-wrapper.jar build(dns block)If you need me to access, download, or install something from one of these locations, you can either:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.