Internal - Room Search Fix

[nushea]

Description

Fixes the rerender cycle by making it sure it redoes the math if the state changes instead

It doesn't have or need a changelog as it is a bug encountered only in the dev branch

Fixes #

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

AI disclosure:

• Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
• Fully AI generated (explain what all the generated code does in moderate detail).

The callas disregard for the state of the room compelled and educated in writing the pr 😔😔😔

[7w1]

how tf does this fix it lol what did we break

[nushea]

how tf does this fix it lol what did we break

i honestly am not completely sure either, i just tried to nail it with git blame for some 2h and couldnt get it, then i started playing around at random with the code and found that allRooms kept rerendering, but only when it had a toSorted function, so
(original code)

const allRooms = useAtomValue(allRoomsAtom).toSorted(factoryRoomIdByActivity(mx));

if you remove the toSorted

const allRooms = useAtomValue(allRoomsAtom);

it doesnt trigger the issue, it works
but it doesnt matter what is in the sort either for it to break and cause rerenders so sth like

const allRooms = useAtomValue(allRoomsAtom).toSorted((a, b) => a.length - b.length);

which is a nothingburger sorting, it still crashes

[7w1]

lovely
i love typescript/javascript/react/web dev so fun so flawless makes so much sense