PLFM-9398 - code review changes#5508
Merged
nickgros merged 7 commits intoSage-Bionetworks:developfrom Feb 23, 2026
Merged
Conversation
Contributor
nickgros
commented
Feb 11, 2026
nickgros
commented
- Test batching in GridIndexManagerImpl
- Improve tests/mocks for SnapshotRowHandler
- Test http failure after max retries in GridReplicaManagerImplTest
- Move synchronize message logic to GridManagerImpl
- Clean imports in many grid classes
- Test batching in GridIndexManagerImpl - Improve tests/mocks for SnapshotRowHandler - Test http failure after max retries in GridReplicaManagerImplTest - Move synchronize message logic to GridManagerImpl - Clean imports in many grid classes
- fix/simplify tests
- fix GridEventListenerTest
john-hill
approved these changes
Feb 16, 2026
| } | ||
| } | ||
|
|
||
| // TODO: Update tests to properly unit test the snapshot structure and validation metadata instead of just testing that a snapshot is created. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.