Edit base template for orchestration#676
Open
SandhraSokhal wants to merge 3 commits intoSage-Bionetworks:developfrom
Open
Edit base template for orchestration#676SandhraSokhal wants to merge 3 commits intoSage-Bionetworks:developfrom
SandhraSokhal wants to merge 3 commits intoSage-Bionetworks:developfrom
Conversation
marcomarasca
reviewed
Dec 5, 2024
| "PromptType" : "ORCHESTRATION" | ||
| } | ||
| ] | ||
| }, |
Collaborator
There was a problem hiding this comment.
Please double check the template correctness from the trace of the agent. Also please be more specific on what the agent can disclose to the user (e.g. the agent can give a brief description of the tools available but the general system prompt for avoiding disclosing internal prompts and instructions should still be there.)
marcomarasca
requested changes
Dec 10, 2024
Collaborator
marcomarasca
left a comment
marcomarasca
left a comment
There was a problem hiding this comment.
The new prompt implies that the model will always include the function or tools information. I think the prompt should be more specific, and instruct the model that it is allowed to include a list of functions (omitting the function names, since they are not valuable information) when the user asks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.