SAGL-89: support distinct webACL for each stack instance (prod, staging, tst)#763
Closed
xschildw wants to merge 3 commits intoSage-Bionetworks:developfrom
Closed
SAGL-89: support distinct webACL for each stack instance (prod, staging, tst)#763xschildw wants to merge 3 commits intoSage-Bionetworks:developfrom
xschildw wants to merge 3 commits intoSage-Bionetworks:developfrom
Conversation
xschildw
changed the title
brucehoff
approved these changes
Aug 28, 2025
Contributor
Author
|
Replaced by #765 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev stack does not use CDN so the idea of testing in dev and sharing a single webACL for all the prod stack instances does not work. This PR adds support for separate webACL for the stack instances 'prod', 'staging' and 'tst'. We'll have each CDN reference their respective webACL and we'll be able to test on the staging or tst instances.
Also changed the action to count in the webACL.