SWC-7004 - Proof of concept MUI button#5741
Draft
nickgros wants to merge 2 commits intoSage-Bionetworks:developfrom
Draft
SWC-7004 - Proof of concept MUI button#5741nickgros wants to merge 2 commits intoSage-Bionetworks:developfrom
nickgros wants to merge 2 commits intoSage-Bionetworks:developfrom
Conversation
Contributor
nickgros
commented
Jul 16, 2025
nickgros
commented
nickgros
commented
Jul 16, 2025
Comment on lines
+82
to
90
| <MUI:Button | ||
| ui:field="createProjectButton" | ||
| type="DEFAULT" | ||
| icon="PLUS" | ||
| pull="RIGHT" | ||
| text="Create a New Project" | ||
| variant="contained" | ||
| color="primary" | ||
| startIcon="add" | ||
| children="Create a New Project" | ||
| className="pull-right" | ||
| size="small" | ||
| /> |
Contributor
Author
There was a problem hiding this comment.
This component uses the correct theme (Synapse theme, not default MUI theme) because the theme (and other context) is now available globally without DI.
Member
There was a problem hiding this comment.
Nice!
Does this screenshot show a small size button, or was the code updated after the screenshot was taken?
Contributor
Author
There was a problem hiding this comment.
This is a small size button. As you probably noticed, it doesn't match--I put this into a separate PR so we can sort all of those concerns out separately 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.