refactor: replace zap with pluggable Logger interface#223
Open
rjasonadams wants to merge 3 commits intoSaveTheRbtz:mainfrom
Open
refactor: replace zap with pluggable Logger interface#223rjasonadams wants to merge 3 commits intoSaveTheRbtz:mainfrom
rjasonadams wants to merge 3 commits intoSaveTheRbtz:mainfrom
Conversation
- Introduce minimal Logger interface with no external dependencies - Add NoOpLogger as default implementation - Replace *zap.Logger with Logger interface in reader and writer - Remove all zapcore.ObjectEncoder dependencies - Add String() methods to seekTableDescriptor, seekTableFooter, seekTableEntry, and FrameOffsetEntry for clean logging output - Use WithRLogger/WithWLogger for consistency - Include examples showing how to implement custom loggers (including zap adapter) - Successfully remove go.uber.org/zap dependency from pkg module This change allows users to integrate any logging library while keeping the package dependency-free for logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows users to integrate any logging library while keeping the package dependency-free for logging.