Skip to content

refactor: replace zap with pluggable Logger interface#223

Open
rjasonadams wants to merge 3 commits intoSaveTheRbtz:mainfrom
rjasonadams:main
Open

refactor: replace zap with pluggable Logger interface#223
rjasonadams wants to merge 3 commits intoSaveTheRbtz:mainfrom
rjasonadams:main

Conversation

@rjasonadams
Copy link

  • Introduce minimal Logger interface with no external dependencies
  • Add NoOpLogger as default implementation
  • Replace *zap.Logger with Logger interface in reader and writer
  • Remove all zapcore.ObjectEncoder dependencies
  • Add String() methods to seekTableDescriptor, seekTableFooter, seekTableEntry, and FrameOffsetEntry for clean logging output
  • Use WithRLogger/WithWLogger for consistency
  • Include examples showing how to implement custom loggers (including zap adapter)
  • Successfully remove go.uber.org/zap dependency from pkg module

This change allows users to integrate any logging library while keeping the package dependency-free for logging.

- Introduce minimal Logger interface with no external dependencies
- Add NoOpLogger as default implementation
- Replace *zap.Logger with Logger interface in reader and writer
- Remove all zapcore.ObjectEncoder dependencies
- Add String() methods to seekTableDescriptor, seekTableFooter, seekTableEntry, and FrameOffsetEntry for clean logging output
- Use WithRLogger/WithWLogger for consistency
- Include examples showing how to implement custom loggers (including zap adapter)
- Successfully remove go.uber.org/zap dependency from pkg module

This change allows users to integrate any logging library while keeping
the package dependency-free for logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant