feat: add 'join_type' parameter for prejoins in staging#353
feat: add 'join_type' parameter for prejoins in staging#353tkiehn merged 4 commits intoScalefreeCOM:mainfrom
Conversation
- Set Default Value to LEFT
tkiehn
left a comment
There was a problem hiding this comment.
Hi @lorogno,
first of all thanks for opening this PR to extend the package!
I've checked and tried it out and it looks good to me.
The only thing I have changed is the default value of the join_type from upper to lower case to match the syntax in the stage-macros :)
Best Regards
Theo
|
Thanks @tkiehn for the fast review! |
Unfortunately currently this is not possible, although we have something planned in this regard :) So for now, we will take care of updating the documentation |
This Pull Request handles the new feature which is described here: #348
@tkiehn @tkirschke Would be happy if you might take a look into it and tell me your opinion :)
Description
Adds a new Parameter called "join_type" for Prejoining. It allows user to define in specific usecases a Join-Type different than LEFT Join. However, if the parameter is not set, left join is taken as default. Due to that there shouldn't be any issues with backward compatibility.
Examples for now supported Join Types: INNER, LEFT, RIGHT, CROSS, OUTER, FULL
Type of change
How Has This Been Tested?
Tested it on Databricks Environment and checked the compiled Code of existing Staging model in the following usecases:
Test Configuration:
Checklist: