Skip to content

dosbox-staging: Persist drives folder#14793

Merged
z-Fng merged 2 commits intoScoopInstaller:masterfrom
farsil:master
Apr 5, 2026
Merged

dosbox-staging: Persist drives folder#14793
z-Fng merged 2 commits intoScoopInstaller:masterfrom
farsil:master

Conversation

@farsil
Copy link
Copy Markdown
Contributor

@farsil farsil commented Jan 26, 2025

Closes #15223
Closes #14794

This PR adds the drives folder to the persist list of dosbox-staging, version 0.82.0. This is to enable persistence for the drives used in the automount feature, described in the default configuration file:

#                   automount: Mount 'drives/[c]' directories as drives on startup, where [c] is a lower-case
#                              drive letter from 'a' to 'y' (enabled by default). The 'drives' folder can be
#                              provided relative to the current directory or via built-in resources.
#                              Mount settings can be optionally provided using a [c].conf file along-side
#                              the drive's directory, with content as follows:
#                                [drive]
#                                type    = dir, overlay, floppy, or cdrom
#                                label   = custom_label
#                                path    = path-specification, ie: path = %%path%%;c:\tools
#                                override_drive = mount the directory to this drive instead (default empty)
#                                verbose = true or false
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated persistence configuration to ensure the drives directory is retained across runs and upgrades.

@github-actions
Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

dosbox-staging

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@farsil farsil closed this Jan 26, 2025
@farsil farsil reopened this Jan 27, 2025
@farsil farsil marked this pull request as ready for review January 27, 2025 09:29
@z-Fng z-Fng changed the title dosbox-staging@0.82.0: Add drives folder to persist list dosbox-staging: Persist drives folder Apr 5, 2026
@z-Fng
Copy link
Copy Markdown
Member

z-Fng commented Apr 5, 2026

/verify

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1296b0ad-fabe-4c81-a777-7ab8077b8a59

📥 Commits

Reviewing files that changed from the base of the PR and between 7f62e04 and 03a8c5a.

📒 Files selected for processing (1)
  • bucket/dosbox-staging.json

Walkthrough

Updated the bucket manifest for dosbox-staging to persist the drives directory across runs and upgrades, ensuring auto-mounted drives are retained alongside other persisted configuration and resource files.

Changes

Cohort / File(s) Summary
Bucket Manifest Configuration
bucket/dosbox-staging.json
Added "drives" to the persist list to enable persistence of auto-mounted drive directories across installations and updates.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

🐰 A single line, so clean and small,
Drives persist through it all!
No more mounting lost to time,
Auto-folders now sublime. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding persistence for the 'drives' folder in dosbox-staging, which directly corresponds to the file modification.
Description check ✅ Passed The description provides comprehensive context, explains the rationale for the change, references related issues/discussions, includes the configuration documentation, and confirms completion of the contribution checklist.
Linked Issues check ✅ Passed The PR fully addresses issue #14794 by implementing option 2 (persist 'drives') as requested, enabling persistence for auto-mounted drives regardless of working directory.
Out of Scope Changes check ✅ Passed The sole change is adding 'drives' to the persist list in dosbox-staging.json, which is directly aligned with the linked issue's requirements and contains no out-of-scope modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

All changes look good.

Wait for review from human collaborators.

dosbox-staging

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng merged commit f6f3412 into ScoopInstaller:master Apr 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dosbox-staging@0.82.0: Persistence of auto-mounted drives

2 participants