feat: add RustChain MCP reference server#2199
feat: add RustChain MCP reference server#2199createkr wants to merge 3 commits intoScottcjn:mainfrom
Conversation
|
Payout RTC wallet: RTC1d48d848a5aa5ecf2c5f01aa5fb64837daaf2f35 |
Review — Two Deliverables, Two Tracks@createkr — this PR ships two things: 1. MCP Reference Server (
|
Deep Review Complete — Changes Needed On Both Deliverables@createkr — ran this through Codex deep verification against the live API. Found real issues that need fixing before merge. This is not a rejection — your code is the closest to correct of all MCP server submissions. But it needs work. MCP Reference Server — Changes Required
Tests: 38 pass, 66% overall coverage, 41% on the real HTTP client. No hardcoded secrets found. AgentFolio Integration (bounties/issue-2890/) — Changes Required
Tests: 68 pass, 88% coverage, but all are unit mocks — none validate against real endpoints. Reminder: The AgentFolio portion is on hold until 0xbrainkid priority window expires April 16 regardless. Payment Estimate (After Fixes)
What To Fix First
Your code quality is still the best of all competing submissions. These are fixable issues, not architectural problems. |
|
Thanks — I addressed the MCP review items in the latest push. Changes made: switched the console script entry point to the sync wrapper so the installed package no longer exits with an un-awaited coroutine; changed wallet verification to a conservative heuristic because the live endpoint returns with zero balance for arbitrary ids; added a dedicated tool plus required handling for attestation submission; and adjusted miner parsing to match the live shape instead of assuming pagination metadata. I also kept GitHub-backed bounty discovery and documented that it is intentional because the live node returns 404 for . I spot-checked the live node for wallet balance, miner list, and attestation challenge behavior after the patch. Please take another look when convenient. |
43d95cb to
562bc0d
Compare
|
Thanks — I followed your suggestion to keep this PR focused on the MCP deliverable only. I pushed another MCP-only cleanup pass to this branch and left the AgentFolio work for a separate follow-up. This update tightens the live-API alignment: miner pagination now reads the nested object from , the MCP server initialization call is fixed to use the inner MCP server object, wallet verification remains conservative ( only on observed non-zero balance), attestation challenge/nonce flow is documented and enforced, and the docs now clearly state that GitHub is the authoritative bounty source because the live node returns 404 for . I also removed the unsupported assumption from the miner schema/output and corrected the Python requirement to 3.10+ to match the MCP SDK. I reran the MCP test suite and rechecked the live endpoints (, , , , , , , GitHub bounties API). Please take another look when convenient. |
Summary
rustchain-bounties-mcp/Testing