Skip to content

Replace Educe derive macro with manual trait implementations#817

Merged
tyt2y3 merged 2 commits intoSeaQL:masterfrom
svix-jplatte:rm-educe
Oct 1, 2024
Merged

Replace Educe derive macro with manual trait implementations#817
tyt2y3 merged 2 commits intoSeaQL:masterfrom
svix-jplatte:rm-educe

Conversation

@svix-jplatte
Copy link
Contributor

Changes

This PR replaces the one and only use of the educe crate with manual trait implementations of the derived traits.

educe takes more than 10s to compile on my machine, whereas sea-query itself takes less than 5s. To me that is a very heavy dependency for how little it is used. The manual implementations of the traits in question should be easy to read and not hard to maintain.

@tyt2y3
Copy link
Member

tyt2y3 commented Oct 1, 2024

I understand your concern. Derive macros are indeed heavy and educe has some advanced features.
I was just too lazy to write all those by hand haha.

@tyt2y3 tyt2y3 merged commit 126b2a0 into SeaQL:master Oct 1, 2024
@svix-jplatte svix-jplatte deleted the rm-educe branch October 2, 2024 06:58
@github-actions
Copy link

github-actions bot commented Oct 5, 2024

🎉 Released In 0.32.0-rc.2 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@github-actions
Copy link

🎉 Released In 0.32.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants