Replace Educe derive macro with manual trait implementations#817
Replace Educe derive macro with manual trait implementations#817tyt2y3 merged 2 commits intoSeaQL:masterfrom
Conversation
|
I understand your concern. Derive macros are indeed heavy and educe has some advanced features. |
🎉 Released In 0.32.0-rc.2 🎉Thank you everyone for the contribution! |
🎉 Released In 0.32.0 🎉Thank you everyone for the contribution! |
Changes
This PR replaces the one and only use of the
educecrate with manual trait implementations of the derived traits.educetakes more than 10s to compile on my machine, whereassea-queryitself takes less than 5s. To me that is a very heavy dependency for how little it is used. The manual implementations of the traits in question should be easy to read and not hard to maintain.