Fix enum variant names in query filters and outputs#165
Open
Gebatzens wants to merge 2 commits intoSeaQL:mainfrom
Open
Fix enum variant names in query filters and outputs#165Gebatzens wants to merge 2 commits intoSeaQL:mainfrom
Gebatzens wants to merge 2 commits intoSeaQL:mainfrom
Conversation
tyt2y3
force-pushed
the
main
branch
2 times, most recently
from
2de933f to
d24a975
Compare
tyt2y3
force-pushed
the
main
branch
16 times, most recently
from
5801629 to
f19754c
Compare
tyt2y3
force-pushed
the
main
branch
7 times, most recently
from
4e9008c to
ff350b4
Compare
tyt2y3
force-pushed
the
main
branch
3 times, most recently
from
05636d6 to
96f8a13
Compare
tyt2y3
force-pushed
the
main
branch
3 times, most recently
from
a9b503f to
6b1ff0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
The custom naming functions you can supply via the
BuilderContextare not used for enum variants. Instead, upper camel case is hardcoded there.
Not sure if there are more places where this is an issue, I think the mutations part is still missing, but I was not able to test that yet.
I also modified the existing test to use a custom naming function.
Bug Fixes