Skip to content

Commit f1a63fc

Browse files
author
Ashley Scillitoe
authored
Correct platform-specific installs in CI, and add codecov tags (#615)
1 parent 0d46a04 commit f1a63fc

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ jobs:
5151
python -m pip install --upgrade pip setuptools wheel
5252
python -m pip install --upgrade --upgrade-strategy eager -r requirements/dev.txt
5353
python -m pip install --upgrade --upgrade-strategy eager -e .
54-
if [ "$RUNNER_OS" != "Windows" ] && [ ${{ matrix.python }} < '3.10' ]; then # Skip Prophet tests on Windows as installation complex. Skip on Python 3.10 as not supported.
54+
if [ "$RUNNER_OS" != "Windows" ] && ${{ matrix.python-version != '3.10' }}; then # Skip Prophet tests on Windows as installation complex. Skip on Python 3.10 as not supported.
5555
python -m pip install --upgrade --upgrade-strategy eager -e .[prophet]
5656
fi
57-
if [ "$RUNNER_OS" == "Linux"]; then # Currently, we only support KeOps on Linux.
57+
if [ "$RUNNER_OS" == "Linux" ]; then # Currently, we only support KeOps on Linux.
5858
python -m pip install --upgrade --upgrade-strategy eager -e .[keops]
5959
fi
6060
python -m pip install --upgrade --upgrade-strategy eager -e .[tensorflow,torch]
@@ -75,7 +75,7 @@ jobs:
7575
- name: Upload coverage to Codecov
7676
if: ${{ success() }}
7777
run: |
78-
codecov
78+
codecov -F ${{ matrix.os }}-${{ matrix.python-version }}
7979
8080
- name: Build Python package
8181
run: |

.github/workflows/test_all_notebooks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
python -m pip install --upgrade pip setuptools wheel
4242
python -m pip install --upgrade --upgrade-strategy eager -r requirements/dev.txt -r testing/requirements.txt
4343
python -m pip install --upgrade --upgrade-strategy eager -e .
44-
if [ "$RUNNER_OS" != "Windows" ] && [ ${{ matrix.python }} < '3.10' ]; then # Skip Prophet tests on Windows as installation complex. Skip on Python 3.10 as not supported.
44+
if [ "$RUNNER_OS" != "Windows" ] && ${{ matrix.python-version != '3.10' }}; then # Skip Prophet tests on Windows as installation complex. Skip on Python 3.10 as not supported.
4545
python -m pip install --upgrade --upgrade-strategy eager -e .[prophet]
4646
fi
4747
python -m pip install --upgrade --upgrade-strategy eager -e .[torch,tensorflow]

.github/workflows/test_changed_notebooks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
python -m pip install --upgrade pip setuptools wheel
5757
python -m pip install --upgrade --upgrade-strategy eager -r requirements/dev.txt -r testing/requirements.txt
5858
python -m pip install --upgrade --upgrade-strategy eager -e .
59-
if [ "$RUNNER_OS" != "Windows" ] && [ ${{ matrix.python }} < '3.10' ]; then # Skip Prophet tests on Windows as installation complex. Skip on Python 3.10 as not supported.
59+
if [ "$RUNNER_OS" != "Windows" ] && ${{ matrix.python-version != '3.10' }}; then # Skip Prophet tests on Windows as installation complex. Skip on Python 3.10 as not supported.
6060
python -m pip install --upgrade --upgrade-strategy eager -e .[prophet]
6161
fi
6262
python -m pip install --upgrade --upgrade-strategy eager -e .[torch,tensorflow]

setup.cfg

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ addopts =
1111
--tb native
1212
-W ignore
1313
--cov=alibi_detect
14-
--cov-append
1514
--randomly-dont-reorganize
1615
--randomly-seed=0
1716
#-n auto

0 commit comments

Comments
 (0)