Correct platform-specific installs in CI, and add codecov tags#615
Merged
ascillitoe merged 32 commits intoSeldonIO:masterfrom Sep 15, 2022
ascillitoe:master
Merged
Correct platform-specific installs in CI, and add codecov tags#615ascillitoe merged 32 commits intoSeldonIO:masterfrom ascillitoe:master
ascillitoe merged 32 commits intoSeldonIO:masterfrom
ascillitoe:master
Conversation
added 26 commits
September 8, 2022 18:06
This reverts commit 7a72e60.
jklaise
reviewed
Sep 12, 2022
jklaise
reviewed
Sep 12, 2022
ascillitoe
commented
Sep 12, 2022
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 83.58% 77.96% -5.63%
==========================================
Files 207 123 -84
Lines 13840 8749 -5091
==========================================
- Hits 11568 6821 -4747
+ Misses 2272 1928 -344
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Sep 13, 2022
Contributor
Author
|
Note: Once merged we should add tags and remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not actually running some ops dep-dependent tests (
keopsandfbprophet) in CI due to some syntax issues in the github action yaml's. This PR fixes this.Codecov flags are also added so that we can view coverage on a per-build basis.