Fixes to ContextMMDDrift mypy errors and examples#466
Merged
ascillitoe merged 2 commits intoSeldonIO:masterfrom Mar 17, 2022
ascillitoe:context_drift_fixes
Merged
Fixes to ContextMMDDrift mypy errors and examples#466ascillitoe merged 2 commits intoSeldonIO:masterfrom ascillitoe:context_drift_fixes
ascillitoe merged 2 commits intoSeldonIO:masterfrom
ascillitoe:context_drift_fixes
Conversation
added 2 commits
March 17, 2022 17:10
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supresses the mypy errors in
ContextMMDDriftTorch. These occur because we typexandcasnp.ndarrayin the method signature, but then cast them totorch.Tensor. The relevant lines could be unsuppressed in the future if we allow mypy redefinitions.An issue with the heading levels in the example notebooks is fixed.