Skip to content

Update CONTRIBUTING.md#595

Merged
ascillitoe merged 2 commits intomasterfrom
contributing-update
Sep 6, 2022
Merged

Update CONTRIBUTING.md#595
ascillitoe merged 2 commits intomasterfrom
contributing-update

Conversation

@ascillitoe
Copy link
Contributor

@ascillitoe ascillitoe commented Aug 22, 2022

Update CONTRIBUTING.md with a note on where to add class docstrings.

Will do the same for alibi and delete the contributing-update branch upon merge.

@ascillitoe ascillitoe requested a review from mauicv August 22, 2022 12:39
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #595 (06ea59c) into master (0bbe586) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   83.58%   83.55%   -0.03%     
==========================================
  Files         207      207              
  Lines       13838    13803      -35     
==========================================
- Hits        11566    11533      -33     
+ Misses       2272     2270       -2     
Impacted Files Coverage Δ
alibi_detect/utils/_types.py 93.10% <0.00%> (-3.45%) ⬇️
alibi_detect/utils/missing_optional_dependency.py 94.28% <0.00%> (-0.16%) ⬇️
alibi_detect/datasets.py 69.19% <0.00%> (-0.14%) ⬇️
alibi_detect/saving/schemas.py 99.20% <0.00%> (-0.05%) ⬇️
alibi_detect/utils/fetching/fetching.py 0.00% <0.00%> (ø)
alibi_detect/cd/base.py 89.47% <0.00%> (+0.21%) ⬆️
alibi_detect/od/vae.py 90.36% <0.00%> (+1.07%) ⬆️

@mauicv
Copy link
Contributor

mauicv commented Aug 22, 2022

Shall we add a note for those of us who now us VS-code on how to set up auto docstrings? 😆 I'm using this extension

@mauicv
Copy link
Contributor

mauicv commented Aug 22, 2022

Otherwise LGTM! Although why was the docs CI cancelled?

@mauicv
Copy link
Contributor

mauicv commented Aug 22, 2022

Actually another question: How do we document static classes or classes that don't implement an __init__ method? The similarity method backends do this for example.

@ascillitoe
Copy link
Contributor Author

Shall we add a note for those of us who now us VS-code on how to set up auto docstrings? laughing I'm using this extension

Yuck... but yes good idea.

Otherwise LGTM! Although why was the docs CI cancelled?

I don't know... perhaps because I authored the PR via the github UI and it doesn't touch the codebase?

Actually another question: How do we document static classes or classes that don't implement an __init__ method? The similarity method backends do this for example.

Good question. Maybe the convention should be "add docstring in init if it exists, otherwise add to the class-level docstring"?

@ascillitoe
Copy link
Contributor Author

@mauicv just updated following your comments.

@ascillitoe ascillitoe merged commit 586ceea into master Sep 6, 2022
@ascillitoe ascillitoe deleted the contributing-update branch September 6, 2022 08:19
ascillitoe pushed a commit that referenced this pull request Nov 8, 2022
Expand guidance on docstrings for classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants