Feature/tabular warning#606
Merged
ascillitoe merged 3 commits intoSeldonIO:masterfrom Sep 6, 2022
ascillitoe:feature/tabular_warning
Merged
Feature/tabular warning#606ascillitoe merged 3 commits intoSeldonIO:masterfrom ascillitoe:feature/tabular_warning
ascillitoe merged 3 commits intoSeldonIO:masterfrom
ascillitoe:feature/tabular_warning
Conversation
Codecov Report
@@ Coverage Diff @@
## master #606 +/- ##
=======================================
Coverage 83.58% 83.58%
=======================================
Files 207 207
Lines 13838 13840 +2
=======================================
+ Hits 11566 11568 +2
Misses 2272 2272
|
arnaudvl
suggested changes
Sep 6, 2022
alibi_detect/cd/tabular.py
Outdated
| # No categories_per_feature dict so assume no categorical features present | ||
| else: | ||
| self.x_ref_categories, self.cat_vars = {}, [] | ||
| warnings.warn('No `categories_per_feature` dict provided so all features are assumed to be categorical. ' |
Contributor
There was a problem hiding this comment.
"... all features are assumed to be numerical." instead of categorical.
Contributor
Author
There was a problem hiding this comment.
Ooops, good spot, thanks!
Contributor
Author
There was a problem hiding this comment.
Corrected now! 👍🏻
arnaudvl
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #588.
The following warning is raised when a
categories_per_featuredict is not provided: