Skip to content

Ignore tests in codecov#614

Merged
ascillitoe merged 2 commits intoSeldonIO:masterfrom
ascillitoe:master
Sep 9, 2022
Merged

Ignore tests in codecov#614
ascillitoe merged 2 commits intoSeldonIO:masterfrom
ascillitoe:master

Conversation

@ascillitoe
Copy link
Contributor

@ascillitoe ascillitoe commented Sep 8, 2022

Update codecov setting to ignore test directories.

Alibi equivalent to be opened post-approval.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #614 (b1a1326) into master (571d501) will decrease coverage by 1.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
- Coverage   83.58%   82.14%   -1.44%     
==========================================
  Files         207      209       +2     
  Lines       13840    14159     +319     
==========================================
+ Hits        11568    11631      +63     
- Misses       2272     2528     +256     
Impacted Files Coverage Δ
alibi_detect/cd/tests/test_learned_kernel.py 83.82% <0.00%> (-12.26%) ⬇️
alibi_detect/cd/learned_kernel.py 95.65% <0.00%> (-4.35%) ⬇️
alibi_detect/utils/keops/kernels.py 0.00% <0.00%> (ø)
alibi_detect/utils/keops/__init__.py 0.00% <0.00%> (ø)
alibi_detect/tests/test_dep_management.py 18.36% <0.00%> (ø)
...detect/cd/keops/tests/test_learned_kernel_keops.py 36.36% <0.00%> (ø)
alibi_detect/cd/keops/learned_kernel.py 0.00% <0.00%> (ø)
alibi_detect/saving/schemas.py 99.25% <0.00%> (+<0.01%) ⬆️
...ibi_detect/utils/keops/tests/test_kernels_keops.py 32.32% <0.00%> (+0.18%) ⬆️

@ascillitoe
Copy link
Contributor Author

Revised coverage below. Looks like the desired files are being ignored...

image

@ascillitoe ascillitoe requested a review from jklaise September 9, 2022 10:05
@jklaise
Copy link
Contributor

jklaise commented Sep 9, 2022

Not sure why the folders/files still appear on the PR view:
image

Otherwise looks good (do we need to ignore conftest.py too or are they covered by ignoring tests folders?). Care to open the same in alibi? :)

@ascillitoe
Copy link
Contributor Author

Not sure why the folders/files still appear on the PR view:

I'm hoping it is because codecov.yml needs to be in master before it takes effect. My screenshot above was from me manually running codecov on my master fork and uploading to my personal codecov account. Not 100% sure how else to verify without just merging and seeing what happens...

@ascillitoe
Copy link
Contributor Author

p.s. as you say I think conftest should be ignored as long as they are tests/ directories.

@ascillitoe ascillitoe merged commit faca234 into SeldonIO:master Sep 9, 2022
ascillitoe pushed a commit that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants