Remove config_spec versioning#641
Merged
ascillitoe merged 3 commits intoSeldonIO:masterfrom Sep 30, 2022
ascillitoe:feature/remove_config_spec
Merged
Remove config_spec versioning#641ascillitoe merged 3 commits intoSeldonIO:masterfrom ascillitoe:feature/remove_config_spec
ascillitoe merged 3 commits intoSeldonIO:masterfrom
ascillitoe:feature/remove_config_spec
Conversation
jklaise
approved these changes
Sep 29, 2022
Contributor
jklaise
left a comment
jklaise
left a comment
There was a problem hiding this comment.
LGTM. Perhaps worth keeping with the convention of adding lines to the development version of the changelog?
Contributor
Author
Good idea! Will do that now |
added 2 commits
September 30, 2022 14:24
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #641 +/- ##
==========================================
- Coverage 78.85% 78.83% -0.02%
==========================================
Files 123 123
Lines 8753 8747 -6
==========================================
- Hits 6902 6896 -6
Misses 1851 1851
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ascillitoe
pushed a commit
that referenced
this pull request
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
config_specversion number. This was added in v0.10.0, as an addition to the usualversionnumber. This was intended to be distinct fromversion, with the idea being it would be used to signify changes to the format of the alibi-detect detector configuration file. However, it has proven to be of limited use, and leads to confusion (+ additional maintainability version). Since we don't guarantee save/load compatibility acrossversion's, theconfig_specnumber is simply not needed.