Skip to content

Set fail_ci_if_error to false on codecov github acton#776

Merged
mauicv merged 1 commit intoSeldonIO:masterfrom
mauicv:bugfix/stop-codecov-ci-fail
Apr 24, 2023
Merged

Set fail_ci_if_error to false on codecov github acton#776
mauicv merged 1 commit intoSeldonIO:masterfrom
mauicv:bugfix/stop-codecov-ci-fail

Conversation

@mauicv
Copy link
Contributor

@mauicv mauicv commented Apr 24, 2023

What is this

Sets fail_ci_if_error=false in the codecov github ci. Quick fix that prevents the ci from falling due to this issue. See also #768

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #776 (a888212) into master (98a2802) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
- Coverage   81.02%   80.96%   -0.06%     
==========================================
  Files         146      146              
  Lines        9716     9716              
==========================================
- Hits         7872     7867       -5     
- Misses       1844     1849       +5     

see 2 files with indirect coverage changes

@ascillitoe
Copy link
Contributor

The ubuntu-latest, 3.9 build gives us an example of the codecov upload failing and CI still passing (which is what we want) 👍🏻

@mauicv mauicv merged commit 8a945ce into SeldonIO:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants