fix: Remove explicit dependency#1002
Merged
mauicv merged 1 commit intoSeldonIO:masterfrom Mar 8, 2024
jesse-c:bump-pydantic-v2
Merged
fix: Remove explicit dependency#1002mauicv merged 1 commit intoSeldonIO:masterfrom jesse-c:bump-pydantic-v2
mauicv merged 1 commit intoSeldonIO:masterfrom
jesse-c:bump-pydantic-v2
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1002 +/- ##
=======================================
Coverage 85.23% 85.23%
=======================================
Files 74 74
Lines 8834 8834
=======================================
Hits 7530 7530
Misses 1304 1304 |
mauicv
approved these changes
Mar 8, 2024
Contributor
mauicv
left a comment
mauicv
left a comment
There was a problem hiding this comment.
1 minor point that i'm not too fussed about but otherwise LGTM!
sakoush
reviewed
Mar 8, 2024
Let the resolver work it out.
jesse-c
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not directly used. Relax the constraint, so the package can be used elsewhere.
Update: Let the resolver work it out.