fix CFRL tabular example#651
Merged
RobertSamoilescu merged 2 commits intoSeldonIO:masterfrom May 6, 2022
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
=======================================
Coverage 80.46% 80.46%
=======================================
Files 77 77
Lines 10635 10635
=======================================
Hits 8557 8557
Misses 2078 2078
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an error in the AE training procedure.
Previously, the AE target was set as follows:
where
This wrongly assumed that the preprocessor outputs the numerical columns and then the categorical ones.
To fix the issue, one can use the output of the
heae_preprocesswhich always outputs first the numerical columns and then the categorical ones.Might be related to the issue #573